sapi: remove reimplementations of (un)setenv - #23287
Open
NattyNarwhal wants to merge 1 commit into
Open
Conversation
These are functions that have existed since Unix V7. Windows doesn't have them, but we don't support FPM on Windows (and in ext/standard, there are other ways to emulate it that don't involve WTF comments). clearenv is kept as this was from a rejected POSIX proposal that only some systems implement (Linux, FreeBSD, some 90s Unices). Also removes the WTF comment incidentally; see phpGH-23285.
NattyNarwhal
changed the title
NattyNarwhal
force-pushed
the
fpm-remove-wtf-setenv
branch
from
August 18, 2026 19:32
b9dd926 to
742254f
Compare
Member
Author
|
FWIW, I had a commit to remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are functions that have existed since Unix V7. Windows doesn't have them, but we don't support FPM on Windows (and in ext/standard, there are other ways to emulate it that don't involve WTF comments).
clearenv is kept as this was from a rejected POSIX proposal that only some systems implement (Linux, FreeBSD, some 90s Unices).
Also removes the WTF comment incidentally; see GH-23285.